Bug 257175 - Use OptionSet<PlatformEventModifier> instead of raw modifier flags in WebCore/page/Chrome
Summary: Use OptionSet<PlatformEventModifier> instead of raw modifier flags in WebCore...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-22 18:32 PDT by Abrar Rahman Protyasha
Modified: 2023-05-25 09:45 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Abrar Rahman Protyasha 2023-05-22 18:32:43 PDT 
Currently we pass event modifiers as unsigned integral values rather than option sets into WebCore/page/Chrome. We should change this and pass around OptionSet<PlatformEventModifier> instead, which will allow us to roundtrip between the UI process and web process without translating between raw modifier flag values and option sets.
Comment 1 Radar WebKit Bug Importer 2023-05-22 18:32:54 PDT 
<rdar://problem/109690336>
Comment 2 Abrar Rahman Protyasha 2023-05-22 22:54:36 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14230
Comment 3 EWS 2023-05-25 09:45:14 PDT 
Committed 264519@main (310ec15a368c): <https://commits.webkit.org/264519@main>

Reviewed commits have been landed. Closing PR #14230 and removing active labels.