WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
257175
Use OptionSet<PlatformEventModifier> instead of raw modifier flags in WebCore/page/Chrome
https://bugs.webkit.org/show_bug.cgi?id=257175
Summary
Use OptionSet<PlatformEventModifier> instead of raw modifier flags in WebCore...
Abrar Rahman Protyasha
Reported
2023-05-22 18:32:43 PDT
Currently we pass event modifiers as unsigned integral values rather than option sets into WebCore/page/Chrome. We should change this and pass around OptionSet<PlatformEventModifier> instead, which will allow us to roundtrip between the UI process and web process without translating between raw modifier flag values and option sets.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-05-22 18:32:54 PDT
<
rdar://problem/109690336
>
Abrar Rahman Protyasha
Comment 2
2023-05-22 22:54:36 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/14230
EWS
Comment 3
2023-05-25 09:45:14 PDT
Committed
264519@main
(310ec15a368c): <
https://commits.webkit.org/264519@main
> Reviewed commits have been landed. Closing PR #14230 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug