Bug 257225 - [css-flexbox] Rename RenderFlexibleBox::LineContext to RenderFlexibleBox::LineState
Summary: [css-flexbox] Rename RenderFlexibleBox::LineContext to RenderFlexibleBox::Lin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-23 14:18 PDT by Sammy Gill
Modified: 2023-05-24 18:50 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-05-23 14:18:56 PDT 
This struct is used and modified at various points during flex layout. The "context," portion of the name almost implies some level of immutability, but we only pass it around as const during select parts of the code path. Instead let's call it "state." since some of the members will get modified as we go through flex layout.
Comment 1 Radar WebKit Bug Importer 2023-05-23 14:19:15 PDT 
<rdar://problem/109738350>
Comment 2 Sammy Gill 2023-05-23 16:45:22 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14273
Comment 3 EWS 2023-05-24 18:50:03 PDT 
Committed 264500@main (c8996adb7069): <https://commits.webkit.org/264500@main>

Reviewed commits have been landed. Closing PR #14273 and removing active labels.