Bug 257233 - [baseline-alignment] Rename BaselineContext
Summary: [baseline-alignment] Rename BaselineContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-23 15:40 PDT by Sammy Gill
Modified: 2023-05-24 14:23 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-05-23 15:40:42 PDT
Whenever we use BaselineContext for baseline alignment, it is continually modifying its state by inserting items into the appropriate baseline sharing groups. We should remove the "context," portion of this name and rename it to something a bit more appropriate that makes it obvious it is there to help manage the baseline sharing groups in different formatting contexts.
Comment 1 Radar WebKit Bug Importer 2023-05-23 15:41:00 PDT
<rdar://problem/109742609>
Comment 2 Sammy Gill 2023-05-23 15:57:31 PDT
Also, a baseline alignment context is something that is part of a specific formatting context. For example, in flex layout the baseline alignment contexts are the flex lines. 

Based off of that I don't think it's appropriate for a formatting context to "create" an object called BaselineContext
Comment 3 Sammy Gill 2023-05-23 16:39:50 PDT
Pull request: https://github.com/WebKit/WebKit/pull/14271
Comment 4 EWS 2023-05-24 14:23:03 PDT
Committed 264484@main (48c6a9eda4fd): <https://commits.webkit.org/264484@main>

Reviewed commits have been landed. Closing PR #14271 and removing active labels.