Bug 257267 - Display property as specified on svg elements
Summary: Display property as specified on svg elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: https://jsfiddle.net/wu4a065f/
Keywords: BrowserCompat, InRadar
Depends on:
Blocks:
 
Reported: 2023-05-24 10:16 PDT by Ahmad Saleem
Modified: 2023-05-27 07:31 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-05-24 10:16:28 PDT 
Hi Team,

While going through Blink's commit, I came across another potential merge, where we are failing quite a lot of tests but still fail 'display: content' after merging this commit, which might be bug mentioned in 'See Also'.

Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=177649

WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/css/CSSProperties.json (Line 473) & All instances from here: https://searchfox.org/wubkat/source/Source/WebCore/style/StyleBuilderCustom.h#1132 (for isValidDisplayValue) (complete functions, where it is mentioned).

Failing test case is in 'URL' field.

______

This will need to be rebase lined:

display-contents-svg-anchor-child.html

____

Thanks!
Comment 1 Ahmad Saleem 2023-05-24 14:35:32 PDT 
Display Content failure might be due to this as well: https://github.com/WebKit/WebKit/blob/cb0b8f5fb7c37ef6ef0883ad83ec2d79b6947616/Source/WebCore/style/StyleAdjuster.cpp#L607
Comment 2 EWS 2023-05-27 07:30:08 PDT 
Committed 264627@main (86a5ffe6350f): <https://commits.webkit.org/264627@main>

Reviewed commits have been landed. Closing PR #14421 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-05-27 07:31:16 PDT 
<rdar://problem/109928375>