Bug 257303 - Remove duplicate DNS lookup implementation and migrate away from deprecated CFHost API
Summary: Remove duplicate DNS lookup implementation and migrate away from deprecated C...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-24 21:35 PDT by Alex Christensen
Modified: 2023-05-29 01:39 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2023-05-24 21:35:17 PDT 
...
Comment 1 Radar WebKit Bug Importer 2023-05-24 21:35:33 PDT 
<rdar://problem/109812699>
Comment 2 Alex Christensen 2023-05-24 21:38:58 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14326
Comment 3 EWS 2023-05-26 09:04:30 PDT 
Committed 264586@main (5a0dc0c7e3a5): <https://commits.webkit.org/264586@main>

Reviewed commits have been landed. Closing PR #14326 and removing active labels.
Comment 4 Diego Pino 2023-05-29 00:55:41 PDT 
GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 post-commit bot build is failing after this patch with the following error:

```
../../Source/WebCore/platform/network/DNS.cpp:52:73: error: no match for call to ‘(WebCore::DNSCompletionHandler {aka WTF::CompletionHandler<void(std::experimental::fundamentals_v3::expected<WTF::Vector<WebCore::IPAddress>, WebCore::DNSError>&&)>}) (Unexpected<WebCore::DNSError>)’
   52 |         return completionHandler(makeUnexpected(DNSError::CannotResolve));
      |                                                                    
```

https://build.webkit.org/#/builders/30/builds/8528
Comment 5 Diego Pino 2023-05-29 00:56:29 PDT 
Re-opening for pull request https://github.com/webkit/webkit/pull/14447
Comment 6 EWS 2023-05-29 01:39:03 PDT 
Committed 264651@main (e2d7aa707d71): <https://commits.webkit.org/264651@main>

Reviewed commits have been landed. Closing PR #14447 and removing active labels.