Bug 257333 - Follow-up fixes after 264515@main
Summary: Follow-up fixes after 264515@main
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-25 09:57 PDT by Michael Catanzaro
Modified: 2023-05-25 11:14 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-05-25 09:57:26 PDT 
Fix indentation error and also:

/home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1576:71: error: cannot pass object of non-trivial type 'WeakPtr<MediaPlayer>' through variadic function; call will abort at runtime [-Wnon-pod-varargs]
        gst_structure_set(contextStructure, "player", G_TYPE_POINTER, m_player, nullptr);
                                                                      ^
1 error generated.
Comment 1 Michael Catanzaro 2023-05-25 09:58:28 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14351
Comment 2 EWS 2023-05-25 11:14:27 PDT 
Committed 264529@main (ee059a1e6a73): <https://commits.webkit.org/264529@main>

Reviewed commits have been landed. Closing PR #14351 and removing active labels.