Bug 257376 - [WPE][GTK] Flatpak check on host without flatpak throws a traceback
Summary: [WPE][GTK] Flatpak check on host without flatpak throws a traceback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-26 05:26 PDT by Philippe Normand
Modified: 2023-05-26 08:14 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2023-05-26 05:26:44 PDT 
Traceback (most recent call last):                                                                                                                                                                                   
  File "/var/home/phil/WebKit/Tools/Scripts/run-webkit-tests", line 43, in <module>                                                                                                                                  
    flatpakutils.run_in_sandbox_if_available(sys.argv)                                                                                                                                                               
  File "/var/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 1341, in run_in_sandbox_if_available                                                                                                              
    if not check_flatpak(verbose=False):                                                                                                                                                                             
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                                              
  File "/var/home/phil/WebKit/Tools/flatpak/flatpakutils.py", line 204, in check_flatpak                                                                                                                             
    version = output.split(" ")[1].strip("\n")                                                                                                                                                                       
              ^^^^^^                                                                                                                                                                                                 
UnboundLocalError: cannot access local variable 'output' where it is not associated with a value
Comment 1 Philippe Normand 2023-05-26 05:28:34 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14388
Comment 2 EWS 2023-05-26 08:14:37 PDT 
Committed 264583@main (cfc421c1dc1b): <https://commits.webkit.org/264583@main>

Reviewed commits have been landed. Closing PR #14388 and removing active labels.