Bug 257410 - AX: AXTextMarkerRangeForTextMarkersAttribute needs to support unordered TextMarkers.
Summary: AX: AXTextMarkerRangeForTextMarkersAttribute needs to support unordered TextM...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-26 18:48 PDT by Andres Gonzalez
Modified: 2023-05-31 11:03 PDT (History)
10 users (show)

See Also:

Attachments
Patch (10.04 KB, patch)
2023-05-26 19:41 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (10.15 KB, patch)
2023-05-30 09:10 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (10.09 KB, patch)
2023-05-30 11:37 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2023-05-26 18:48:10 PDT 
It only works when the passed TextMarkers are ordered, i.e., start < end.
Comment 1 Radar WebKit Bug Importer 2023-05-26 18:48:23 PDT 
<rdar://problem/109914853>
Comment 2 Andres Gonzalez 2023-05-26 18:48:54 PDT 
<rdar://problem/109815930>
Comment 3 Radar WebKit Bug Importer 2023-05-26 18:49:07 PDT 
<rdar://problem/109914891>
Comment 4 Andres Gonzalez 2023-05-26 19:41:48 PDT 
Created attachment 466512 [details]
Patch
Comment 5 Andres Gonzalez 2023-05-26 19:52:38 PDT 
rdar://problem/109815930
Comment 6 Andres Gonzalez 2023-05-30 09:10:37 PDT 
Created attachment 466535 [details]
Patch
Comment 7 Andres Gonzalez 2023-05-30 11:37:00 PDT 
Created attachment 466536 [details]
Patch
Comment 8 chris fleizach 2023-05-31 07:40:33 PDT 
Comment on attachment 466536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466536&action=review

> Source/WebCore/accessibility/AXTextMarker.cpp:290
> +        auto startBoundaryPoint = marker1.boundaryPoint();

are these pointers? should they be auto*
Comment 9 Andres Gonzalez 2023-05-31 08:39:56 PDT 
(In reply to chris fleizach from comment #8)
> Comment on attachment 466536 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=466536&action=review
> 
> > Source/WebCore/accessibility/AXTextMarker.cpp:290
> > +        auto startBoundaryPoint = marker1.boundaryPoint();
> 
> are these pointers? should they be auto*

No, std::optional.
Comment 10 EWS 2023-05-31 11:03:42 PDT 
Committed 264742@main (b37f820dae2a): <https://commits.webkit.org/264742@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466536 [details].