Bug 257422 - Documents with many lines overallocated pagination information
Summary: Documents with many lines overallocated pagination information
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-27 10:36 PDT by Ahmad Saleem
Modified: 2023-05-31 07:45 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-05-27 10:36:41 PDT
Hi Team,

I came across potential memory saving commit from Blink, which we can merge, if we can have AB test to confirm, it does benefit us.

Blink Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=170497

Testcase URL (used by Blink): http://norvig.com/big.txt

WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/rendering/LegacyRootInlineBox.cpp#288

^ It is in Legacy Inline rather than IFC. So don't know how much we can benefit from it.

_________

This compiles:

auto* layoutState = blockFlow().view().frameView().layoutContext().layoutState();
    if (layoutState->isPaginated())
        setPaginatedLineWidth(blockFlow().availableLogicalWidthForContent(heightOfBlock));

_________

Just wanted to raise to get input and insight.

Thanks!
Comment 1 Ahmad Saleem 2023-05-31 07:45:04 PDT
Based on discussion with Alan over Slack 1-1, this is not applicable.