Bug 257428 - [popover] Refactor all popover showing checks
Summary: [popover] Refactor all popover showing checks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: GoodFirstBug, InRadar
Depends on:
Blocks: 250171
  Show dependency tree / graph
 
Reported: 2023-05-27 14:04 PDT by Tim Nguyen (:ntim)
Modified: 2023-06-03 18:41 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2023-05-27 14:04:30 PDT 
popoverData() && popoverData()->visibilityState() == PopoverVisibilityState::Showing 

is a very common check across the codebase, we should have a helper function (isShowingPopover / isOpenPopover?)
Comment 1 Rob Buis 2023-05-30 09:30:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14487
Comment 2 EWS 2023-05-30 12:57:07 PDT 
Committed 264693@main (415cdc82121c): <https://commits.webkit.org/264693@main>

Reviewed commits have been landed. Closing PR #14487 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-05-30 12:58:18 PDT 
<rdar://problem/110020705>