Bug 257437 - Remove redundant RenderTextControl::textBlockLogicalWidth
Summary: Remove redundant RenderTextControl::textBlockLogicalWidth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-27 21:36 PDT by zalan
Modified: 2023-05-28 19:18 PDT (History)
14 users (show)

See Also:

Attachments
Patch (4.42 KB, patch)
2023-05-27 21:38 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.44 KB, patch)
2023-05-27 21:40 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-05-27 21:36:53 PDT 
ssia
Comment 1 zalan 2023-05-27 21:38:26 PDT 
Created attachment 466522 [details]
Patch
Comment 2 zalan 2023-05-27 21:40:05 PDT 
Created attachment 466523 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2023-05-28 09:58:34 PDT 
Comment on attachment 466523 [details]
Patch

LGTM
Comment 4 Tim Nguyen (:ntim) 2023-05-28 10:01:02 PDT 
Comment on attachment 466523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466523&action=review

> Source/WebCore/rendering/RenderTextControl.cpp:-91
> -int RenderTextControl::textBlockLogicalHeight() const
> -{
> -    return logicalHeight() - borderAndPaddingLogicalHeight();
> -}
> -
> -int RenderTextControl::textBlockLogicalWidth() const

Please remove from header file as well.
Comment 5 zalan 2023-05-28 18:29:21 PDT 
(In reply to Tim Nguyen (:ntim) from comment #4)
> Comment on attachment 466523 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=466523&action=review
> 
> > Source/WebCore/rendering/RenderTextControl.cpp:-91
> > -int RenderTextControl::textBlockLogicalHeight() const
> > -{
> > -    return logicalHeight() - borderAndPaddingLogicalHeight();
> > -}
> > -
> > -int RenderTextControl::textBlockLogicalWidth() const
> 
> Please remove from header file as well.
I did, didn't I?
Comment 6 zalan 2023-05-28 18:29:56 PDT 
(In reply to Tim Nguyen (:ntim) from comment #3)
> Comment on attachment 466523 [details]
> Patch
> 
> LGTM

Thank you.
Comment 7 EWS 2023-05-28 19:17:50 PDT 
Committed 264645@main (400b4102ecf3): <https://commits.webkit.org/264645@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466523 [details].
Comment 8 Radar WebKit Bug Importer 2023-05-28 19:18:17 PDT 
<rdar://problem/109957291>