Bug 257443 - RemoteLayerTreeDisplayRefreshMonitor::displayNominalFramesPerSecond returns the preferred frames per second
Summary: RemoteLayerTreeDisplayRefreshMonitor::displayNominalFramesPerSecond returns t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-05-28 14:56 PDT by Matt Woodrow
Modified: 2023-05-31 22:20 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Woodrow 2023-05-28 14:56:38 PDT 
displayNominalFramesPerSecond is intended to return the refresh rate of the display, but RemoteLayerTreeDisplayRefreshMonitor returns the preferred value set by the Page. This might be the nominal rate, but could also be a lower value if the Page applied throttling.

The only caller of this function is Page, so it's a circular dependency, that can't return any useful information.

I'm not aware of current bugs from this, but it seems plausible that we'd issue a windowScreenDidChange on iOS, and retrieve a throttled rate from the existing refresh monitor.
Comment 1 Radar WebKit Bug Importer 2023-05-28 14:57:19 PDT 
<rdar://problem/109953270>
Comment 2 Matt Woodrow 2023-05-28 15:08:15 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14444
Comment 3 EWS 2023-05-31 22:20:32 PDT 
Committed 264775@main (e85bed10ffa8): <https://commits.webkit.org/264775@main>

Reviewed commits have been landed. Closing PR #14444 and removing active labels.