Bug 257464 - release 2.40.2 fails to build with bubblewrap disabled
Summary: release 2.40.2 fails to build with bubblewrap disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: All Other
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-29 11:53 PDT by Antoine Jacoutot
Modified: 2023-06-01 01:07 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Jacoutot 2023-05-29 11:53:14 PDT 
Hi.

The commit https://github.com/WebKit/WebKit/commit/4c39f38757287198c49091ee12fc548cc9c212d6 implied that BWRAP_EXECUTABLE is always defined.
However, when building with BUBBLEWRAP_SANDBOX=Off, Source/cmake/BubblewrapSandboxChecks.cmake is not used and hence BWRAP_EXECUTABLE is not set.

/usr/ports/pobj/webkitgtk41-2.40.2-webkitgtk41/webkitgtk-2.40.2/Source/WTF/wtf/glib/Sandbox.cpp:49:13: error: use of undeclared identifier 'BWRAP_EXECUTABLE'
            BWRAP_EXECUTABLE,
            ^
1 error generated.
Comment 1 Antoine Jacoutot 2023-06-01 01:07:20 PDT 
Fixed with commit https://github.com/WebKit/WebKit/commit/4977290ab4ab35258a6da9b13795c9b0f7894bf4