Bug 257631 - ::isFullscreen() and ::fullscreenElement() can lead to confusion
Summary: ::isFullscreen() and ::fullscreenElement() can lead to confusion
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marcos Caceres
URL:
Keywords: InRadar
Depends on:
Blocks: fullscreen-cleanup
  Show dependency tree / graph
 
Reported: 2023-06-01 20:52 PDT by Marcos Caceres
Modified: 2024-07-20 21:40 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcos Caceres 2023-06-01 20:52:38 PDT 
For legacy reasons, we had an old web expose "webkitIsFullscreen()", which got changed to `isFullscreen()` and `::fullscreenElement()`, which is the recommended/standard way of checking for the fullscreen element... however, having two methods is confusing because they are subtly different in behavior. 

We should just have a single API, preferably the one that matches the standard (i.e., use ::fullscreenElement() everywhere and get rid of the old one that we don't need anymore).
Comment 1 Radar WebKit Bug Importer 2023-06-08 20:53:16 PDT 
<rdar://problem/110505689>