Bug 257641 - Remove unnecessary check in `TreeResolver::resolvePseudoElement()`
Summary: Remove unnecessary check in `TreeResolver::resolvePseudoElement()`
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-02 01:11 PDT by Vitaly Dyackhov
Modified: 2023-06-20 07:12 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Dyackhov 2023-06-02 01:11:15 PDT 
```
    // FIXME: This test shouldn't be needed.
    bool alwaysNeedsPseudoElement = resolvedStyle->style->hasAnimationsOrTransitions()
        || element.hasKeyframeEffects(pseudoId)
        || pseudoId == PseudoId::FirstLine
        || pseudoId == PseudoId::FirstLetter
        || pseudoId == PseudoId::Scrollbar;
    if (!alwaysNeedsPseudoElement && !pseudoElementRendererIsNeeded(resolvedStyle->style.get()))
        return { };
```
Comment 1 Vitaly Dyackhov 2023-06-02 01:14:39 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14620
Comment 2 Radar WebKit Bug Importer 2023-06-09 01:12:15 PDT 
<rdar://problem/110515283>
Comment 3 EWS 2023-06-20 07:12:06 PDT 
Committed 265318@main (ad52c1163560): <https://commits.webkit.org/265318@main>

Reviewed commits have been landed. Closing PR #14620 and removing active labels.