Bug 257647 - ThreadSafeObjectHeap lacks add and remove operations
Summary: ThreadSafeObjectHeap lacks add and remove operations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-02 08:00 PDT by Kimmo Kinnunen
Modified: 2023-06-12 04:44 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2023-06-02 08:00:14 PDT 
ThreadSafeObjectHeap lacks add and remove operations

Currently it has "add if not present" and "remove if present". This is suboptimal because it has to support the remove arriving before add, but "if present" part makes leaked entries impossible to avoid.
Comment 1 Radar WebKit Bug Importer 2023-06-02 08:00:27 PDT 
<rdar://problem/110169358>
Comment 2 Kimmo Kinnunen 2023-06-07 05:41:07 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14734
Comment 3 EWS 2023-06-12 04:44:27 PDT 
Committed 265063@main (ecb76a449ffa): <https://commits.webkit.org/265063@main>

Reviewed commits have been landed. Closing PR #14734 and removing active labels.