Bug 257648 - [GTK] Remove support for OpenGL API in the web process
Summary: [GTK] Remove support for OpenGL API in the web process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2023-06-02 08:06 PDT by Carlos Garcia Campos
Modified: 2023-06-09 06:14 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-06-02 08:06:02 PDT 
Right now it's a buildtime option, USE(OPENGL) and USE(OPENGL_ES) are mutually exclusive. Since OpenGL is the default, we sometimes break OPENGL_ES build by mistake, or even rendering since it's untested. Making it possible to decide the API at runtime allows to easily test both cases without having to recompile.
Comment 1 Carlos Garcia Campos 2023-06-02 08:11:24 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14627
Comment 2 Carlos Garcia Campos 2023-06-06 04:17:36 PDT 
While working on making the OpenGL API a runtime decision I realized that we don't really need to keep supporting OpenGL API in the web process. We are the only port still supporting it, so we can remove another code path, some code and conditional compilation.
Comment 3 Carlos Garcia Campos 2023-06-06 04:28:05 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14692
Comment 4 EWS 2023-06-09 06:14:19 PDT 
Committed 265017@main (cfe917fec45b): <https://commits.webkit.org/265017@main>

Reviewed commits have been landed. Closing PR #14692 and removing active labels.