Bug 257717 - Resolutions in calc should always be serialized to dppx
Summary: Resolutions in calc should always be serialized to dppx
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar, WPTImpact
Depends on:
Blocks:
 
Reported: 2023-06-05 09:15 PDT by Tim Nguyen (:ntim)
Modified: 2023-06-23 11:39 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2023-06-05 09:15:17 PDT 
The canonical unit for resolution is dppx, we should always convert resolutions to use that unit.

See failures at: https://wpt.fyi/results/css/css-images/image-set/image-set-parsing.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat
Comment 1 Radar WebKit Bug Importer 2023-06-05 09:15:27 PDT 
<rdar://problem/110265669>
Comment 2 Cheng You Bai (:cybai) 2023-06-21 23:59:02 PDT 
I also noticed the failures in https://wpt.fyi/results/css/mediaqueries/match-media-parsing.html?label=experimental&label=master&aligned related to this issue. May I work on this one?
Comment 3 Ryan Reno 2023-06-22 11:49:10 PDT 
(In reply to Cheng You Bai (:cybai) from comment #2)
> I also noticed the failures in
> https://wpt.fyi/results/css/mediaqueries/match-media-parsing.
> html?label=experimental&label=master&aligned related to this issue. May I
> work on this one?

Please do, thanks!
Comment 4 Cheng You Bai (:cybai) 2023-06-22 23:28:54 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15229
Comment 5 EWS 2023-06-23 11:39:10 PDT 
Committed 265469@main (a4c5bcd2ebf9): <https://commits.webkit.org/265469@main>

Reviewed commits have been landed. Closing PR #15229 and removing active labels.