NEW257854
WPT export should not use the bug URL in the commit subject (title) 
https://bugs.webkit.org/show_bug.cgi?id=257854
Summary WPT export should not use the bug URL in the commit subject (title)
Anne van Kesteren
Reported 2023-06-08 09:01:48 PDT
That's not great context for the upstream project.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-06-12 05:24:30 PDT
<rdar://problem/110638179>
youenn fablet
Comment 2 2023-06-12 05:28:21 PDT
Pull request: https://github.com/WebKit/WebKit/pull/14859
Tim Nguyen (:ntim)
Comment 3 2024-03-08 12:47:52 PST
*** Bug 270349 has been marked as a duplicate of this bug. ***
Sam Sneddon [:gsnedders]
Comment 4 2024-11-04 12:16:16 PST
From the dupe: (In reply to Sam Sneddon [:gsnedders] from comment #0) > Currently Chromium and Mozilla exports contain the full commit message, with > some metadata. e.g. > https://github.com/web-platform-tests/wpt/commit/ > 9aa0f67e426fac988de1625eb6c8926e225df602 (Chromium) or > https://github.com/web-platform-tests/wpt/commit/ > 91dd2eb6f5a512dc4329a0d334e17a498c249f24 (Mozilla). > > By comparison, our exporter produces a commit message like "WebKit export of > https://bugs.webkit.org/show_bug.cgi?id=269971" or "Export made from a > WebKit repository". > > These are much less useful, and provide much less context for the change > being made (especially in the latter case!). Which is arguably broader in scope than just the summary line.
Sam Sneddon [:gsnedders]
Comment 5 2025-06-16 11:52:56 PDT
I do wonder if this is better fixed by using `git-am` rather than `git-apply`; but we should almost certainly add more metadata (e.g., linking to where it was reviewed as is true for Chromium and Firefox). That also then leaves the commit in a state where if there's a merge conflict you can run `git-am --continue` and get the right commit message and author etc.
Sam Sneddon [:gsnedders]
Comment 6 2025-08-26 10:56:26 PDT
I'd suggest, based on our commit messages: * We move bugs away from the summary line (because "Limit the scope of invalidation traversal for :has(> .changed) .subject https://bugs.webkit.org/show_bug.cgi?id=297893 rdar://159173631" is a ridiculous summary line, when you fold whitespace) into `Bug` trailers * Rename our `Canonical Link` "trailer" to `WebKit-Canonical-Link` * Possibly add a `Reviewed-on: [PR]` trailer * Maybe move the "Reviewed by…" line to something more like Chromium's `Reviewed-by: [name] <[email]>` or Mozilla's `gecko-reviewers: [username]`, so that the start of the commit message is the actual content? * Maybe drop the changelog from the commit message? Brianna's code to parse commit messages and extract sections would be helpful here…
Tim Nguyen (:ntim)
Comment 7 2025-08-26 15:13:35 PDT
*** Bug 297925 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.