Bug 257938 - Use smart pointers with PageLoadStateObserverBase subclasses and instance variables
Summary: Use smart pointers with PageLoadStateObserverBase subclasses and instance var...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Process Model (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks: 258051
  Show dependency tree / graph
 
Reported: 2023-06-10 11:47 PDT by David Kilzer (:ddkilzer)
Modified: 2023-06-13 16:28 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-06-10 11:47:20 PDT 
Use smart pointers with PageLoadStateObserverBase subclasses and instance variables.

NavigationState inherits from CanMakeWeakPtr<>, but PageLoadStateObserver should also use a WeakPtr<>.

<rdar://110485192>
Comment 1 David Kilzer (:ddkilzer) 2023-06-10 13:41:01 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14849
Comment 2 EWS 2023-06-13 06:50:48 PDT 
Committed 265120@main (946a761a0a7f): <https://commits.webkit.org/265120@main>

Reviewed commits have been landed. Closing PR #14849 and removing active labels.
Comment 3 David Kilzer (:ddkilzer) 2023-06-13 06:56:47 PDT 
<rdar://110349418>