Bug 257945 - [WGSL][WebGPU] properly compute the address space for the buffer binding
Summary: [WGSL][WebGPU] properly compute the address space for the buffer binding
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 258036 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-06-11 21:48 PDT by Mike Wyrzykowski
Modified: 2023-06-15 08:45 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Wyrzykowski 2023-06-11 21:48:48 PDT 
[WGSL][WebGPU] properly compute the address space for the buffer binding in bindingMemberForGlobal in:

    static BindGroupLayoutEntry::BindingMember bindingMemberForGlobal(auto& global)

in GlobalVariableRewriter.cpp
Comment 1 Radar WebKit Bug Importer 2023-06-11 21:49:08 PDT 
<rdar://problem/110622581>
Comment 2 Mike Wyrzykowski 2023-06-14 13:58:57 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14971
Comment 3 Mike Wyrzykowski 2023-06-14 14:00:17 PDT 
*** Bug 258036 has been marked as a duplicate of this bug. ***
Comment 4 EWS 2023-06-15 08:45:27 PDT 
Committed 265198@main (d98c1f9162a0): <https://commits.webkit.org/265198@main>

Reviewed commits have been landed. Closing PR #14971 and removing active labels.