Bug 257947 - [WebGPU] GPUAutoLayout should have special designation
Summary: [WebGPU] GPUAutoLayout should have special designation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-11 23:04 PDT by Mike Wyrzykowski
Modified: 2023-06-13 14:20 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Wyrzykowski 2023-06-11 23:04:29 PDT
[WebGPU] GPUAutoLayout should have special designation

Currently it is created like so:

    m_autoPipelineLayout(createPipelineLayout({ { "autoLayout"_s, }, { } }))

and relies on the fact that the implementation of PipelineLayout::isValid is:

    bool isValid() const { return !m_bindGroupLayouts.isEmpty(); }

however a pipeline layout may have zero bind group layouts. So we need a special designation for auto layout.
Comment 1 Radar WebKit Bug Importer 2023-06-11 23:04:47 PDT
<rdar://problem/110624583>
Comment 2 Mike Wyrzykowski 2023-06-12 22:05:31 PDT
Pull request: https://github.com/WebKit/WebKit/pull/14905
Comment 3 EWS 2023-06-13 14:20:56 PDT
Committed 265134@main (fc7310ff1cab): <https://commits.webkit.org/265134@main>

Reviewed commits have been landed. Closing PR #14905 and removing active labels.