Bug 257985 - [iOS] Allow syscall-unix SYS_faccessat in the GPU Process sandbox (Part 2)
Summary: [iOS] Allow syscall-unix SYS_faccessat in the GPU Process sandbox (Part 2)
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-12 15:48 PDT by Brent Fulgham
Modified: 2023-06-12 15:58 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2023-06-12 15:48:07 PDT
In Bug 256728, I attempted to enable `SYS_faccessat` in the iOS sandbox, as we had telemetry indicating it was getting hit.

Unfortunately, this caused a memory benchmark to regress by a small amount. Without a strong reason to keep the feature accessible, we decided to silence it to avoid the cost of symbolicating telemetry and reports.

Since then, I have discovered that some aspects of Metal's shader caching needs this value. This patch restores the feature. I will work to determine whether this is a true memory regression, or simply reverting a mistaken memory progression created when we blocked it in our April code release.
Comment 1 Brent Fulgham 2023-06-12 15:57:41 PDT
<rdar://108203015>
Comment 2 Brent Fulgham 2023-06-12 15:58:03 PDT
<rdar://problem/108203015>
Comment 3 Brent Fulgham 2023-06-12 15:58:45 PDT
Pull request: https://github.com/WebKit/WebKit/pull/14895