WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
257985
[iOS] Allow syscall-unix SYS_faccessat in the GPU Process sandbox (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=257985
Summary
[iOS] Allow syscall-unix SYS_faccessat in the GPU Process sandbox (Part 2)
Brent Fulgham
Reported
2023-06-12 15:48:07 PDT
In
Bug 256728
, I attempted to enable `SYS_faccessat` in the iOS sandbox, as we had telemetry indicating it was getting hit. Unfortunately, this caused a memory benchmark to regress by a small amount. Without a strong reason to keep the feature accessible, we decided to silence it to avoid the cost of symbolicating telemetry and reports. Since then, I have discovered that some aspects of Metal's shader caching needs this value. This patch restores the feature. I will work to determine whether this is a true memory regression, or simply reverting a mistaken memory progression created when we blocked it in our April code release.
Attachments
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2023-06-12 15:57:41 PDT
<
rdar://108203015
>
Brent Fulgham
Comment 2
2023-06-12 15:58:03 PDT
<
rdar://problem/108203015
>
Brent Fulgham
Comment 3
2023-06-12 15:58:45 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/14895
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug