Bug 258025 - MobileSafari at WebKit: WebKit::VideoFullscreenModelContext::didEnterFullscreen
Summary: MobileSafari at WebKit: WebKit::VideoFullscreenModelContext::didEnterFullscreen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-13 07:38 PDT by Jean-Yves Avenard [:jya]
Modified: 2023-06-15 06:18 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2023-06-13 07:38:03 PDT 
Occasional crash in Safari:

```
     3 WebKit::PlaybackSessionModelContext::loggerPtr() const <==
        3 WebKit::VideoFullscreenModelContext::loggerPtr() const
          3 WebKit::VideoFullscreenModelContext::didEnterFullscreen(WebCore::FloatSize const&)
            3 WebCore::VideoFullscreenInterfaceAVKit::doEnterFullscreen()
              3 __96-[AVPlayerViewController _transitionToAttachedFullScreenAnimated:interactive:completionHandler:]_block_invoke
                3 -[_UIViewControllerTransitionCoordinator _applyBlocks:releaseBlocks:]
                  3 -[_UIViewControllerTransitionContext _runAlongsideCompletions]
                    3 -[_UIViewControllerTransitionContext completeTransition:]
                      3 __35-[AVTransition completeTransition:]_block_invoke
                        3 -[AVPlayerViewController transitionController:transitionWillComplete:continueBlock:]
                          3 -[AVTransitionController transitionWillComplete:success:continueBlock:]
                            3 -[AVTransition completeTransition:]
                              3 -[UIViewPropertyAnimator _executeCompletionHandlerWithFinalPosition:]
                                3 -[UIViewPropertyAnimator _runCompletions:finished:]
                                  3 __61-[UIViewPropertyAnimator _setupAssociatedViewAnimationState:]_block_invoke
                                    3 __UIVIEW_IS_EXECUTING_ANIMATION_COMPLETION_BLOCK__
                                      3 -[UIViewAnimationBlockDelegate _didEndBlockAnimation:finished:context:]
                                        3 -[UIViewAnimationState sendDelegateAnimationDidStop:finished:]
                                          3 -[UIViewAnimationState animationDidStop:finished:]
                                            3 run_animation_callbacks(void*)
                                              3 _dispatch_client_callout
                                                3 _dispatch_continuation_invoke_inline
                                                  3 _dispatch_continuation_pop_inline
                                                    3 _dispatch_main_queue_drain
                                                      3 _dispatch_main_queue_callback_4CF
                                                        3 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__
                                                          3 __CFRunLoopRun
                                                            3 CFRunLoopRunSpecific
                                                              3 GSEventRunModal
                                                                3 -[UIApplication _run]
                                                                  3 UIApplicationMain
                                                                    3 MobileSafariUIMain
                                                                      3 start
```
Comment 1 Jean-Yves Avenard [:jya] 2023-06-13 07:38:23 PDT 
rdar://110311635
Comment 2 Jean-Yves Avenard [:jya] 2023-06-13 08:41:20 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14924
Comment 3 EWS 2023-06-15 06:18:07 PDT 
Committed 265195@main (9a1b8a792aee): <https://commits.webkit.org/265195@main>

Reviewed commits have been landed. Closing PR #14924 and removing active labels.