Bug 258037 - evaluateJavaScript: and callAsyncJavaScript: should not leave behind transient activation
Summary: evaluateJavaScript: and callAsyncJavaScript: should not leave behind transien...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: Safari 16
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-13 10:58 PDT by Brady Eidson
Modified: 2023-08-17 13:01 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2023-06-13 10:58:20 PDT 
evaluateJavaScript: and callAsyncJavaScript: should not leave being transient activation

For historical momentum reasons, these APIs act as if operating with a user gesture. And that's fine.
But they should not leave behind transient user activation for (currently) 5 seconds after the script completes.

Change the behavior (protected with a linked-on-or-after check)
Comment 1 Brady Eidson 2023-06-13 10:58:31 PDT 
rdar://104748908
Comment 2 Brady Eidson 2023-06-13 11:03:40 PDT 
Pull request: https://github.com/apple/WebKit/pull/645
Comment 3 Brady Eidson 2023-06-14 12:43:04 PDT 
rdar://107102031
Comment 4 Brady Eidson 2023-06-14 12:47:37 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14966
Comment 5 EWS 2023-06-14 15:30:34 PDT 
Committed 265168@main (8e5ddea16577): <https://commits.webkit.org/265168@main>

Reviewed commits have been landed. Closing PR #14966 and removing active labels.
Comment 6 EWS 2023-06-21 10:19:00 PDT 
Committed 259548.840@safari-7615-branch (259842c7afc2): <https://commits.webkit.org/259548.840@safari-7615-branch>

Reviewed commits have been landed. Closing PR #659 and removing active labels.