WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
258051
Stop autoreleasing WKWebView and WKContentView in WebKit::PageClientImplIOS
https://bugs.webkit.org/show_bug.cgi?id=258051
Summary
Stop autoreleasing WKWebView and WKContentView in WebKit::PageClientImplIOS
David Kilzer (:ddkilzer)
Reported
2023-06-13 16:28:36 PDT
Stop autoreleasing WKWebView and WKContentView in WebKit::PageClientImplIOS. Since both m_webView and m_contentView are WeakObjCPtr<> instance variables, calling methods like `[m_webView bar]` results in autoreleasing `m_webView` every time. Fix this by using convenience methods that call WeakObjCPtr<>::get() and return a RetainPtr<> instead.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-06-13 16:29:00 PDT
<
rdar://problem/110740310
>
David Kilzer (:ddkilzer)
Comment 2
2023-06-13 16:35:39 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/14938
EWS
Comment 3
2023-06-14 11:24:17 PDT
Committed
265157@main
(3fe8f3b95be5): <
https://commits.webkit.org/265157@main
> Reviewed commits have been landed. Closing PR #14938 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug