Hi Team, We need to implement 'dirtiness' for HTMLOptionElement to pass following failing WPT tests: Test: https://wpt.fyi/results/html/semantics/forms/the-option-element/option-selected.html?label=experimental&label=master&aligned Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/a17cc1eda58ad8270dc56ebafab215e67e6c1bfe Just wanted to raise, so we can fix it. Thanks!
Seems like an 1:1 port.
Blink patch will cause regression, so this is follow-up: https://chromium.googlesource.com/chromium/src.git/+/f67251360e4b76d188bb1523d7a0952c2f449e68
(In reply to Ahmad Saleem from comment #2) > Blink patch will cause regression, so this is follow-up: > https://chromium.googlesource.com/chromium/src.git/+/ > f67251360e4b76d188bb1523d7a0952c2f449e68 Also another regression: https://chromium.googlesource.com/chromium/src/+/6d095ec7a71eb72e2ad9992d1ca3080f5726f6bf
<rdar://problem/111096541>
I merged these patches and got them compiled but got crashes in three tests. So I might be doing something wrong. Happy to zip and attach screenshots of my local patches.
I tried this again locally and now running via WIP to see what happens - last time it caused crashes locally but this time didn't. https://github.com/WebKit/WebKit/pull/30802 In WIP / Draft - would be good to at least post what I tried locally.
Just documenting progress on bug rather than PR - it leads to failing two tests: accessibility/listbox-clear-selection.html accessibility/select-element-at-index.html I haven't explored yet but good to maintain list (some time old EWS runs are not accessible - hence documenting it here).