Bug 258136 - Web Inspector: REGRESSION(264158@main) Sources tab never shows files when inspecting JS Context
Summary: Web Inspector: REGRESSION(264158@main) Sources tab never shows files when ins...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Razvan Caliman
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-15 08:11 PDT by Razvan Caliman
Modified: 2023-06-15 14:05 PDT (History)
2 users (show)

See Also:

Attachments
Screenshot of uncaught exception (785.96 KB, image/png)
2023-06-15 08:11 PDT, Razvan Caliman 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Razvan Caliman 2023-06-15 08:11:32 PDT 
Created attachment 466702 [details]
Screenshot of uncaught exception

Regressed by https://commits.webkit.org/264158@main in https://github.com/WebKit/WebKit/pull/13617

Unable to inspect JS Contexts because of uncaught exception:

```
TypeError:​ null is not an object (evaluating 'script.displayName')​ (at ScriptTreeElement.js:​32:​39)​
    ScriptTreeElement @ ScriptTreeElement.js:​32:​39
    WorkerTreeElement @ WorkerTreeElement.js:​41:​14
    _addWorkerTargetWithMainResource @ SourcesNavigationSidebarPanel.js:​1317:​57
    _handleResourceGroupingModeChanged @ SourcesNavigationSidebarPanel.js:​2387:​54
    SourcesNavigationSidebarPanel @ SourcesNavigationSidebarPanel.js:​413:​48
    navigationSidebarPanel @ TabContentView.js:​189:​87
    attached @ ContentBrowserTabContentView.js:​98:​17
    _didMoveToParent @ View.js:​272:​30
    insertSubviewBefore @ View.js:​117:​30
    addSubview @ View.js:​89:​33
    _showEntry @ ContentViewContainer.js:​468:​28
    showBackForwardEntryForIndex @ ContentViewContainer.js:​171:​24
    showContentView @ ContentViewContainer.js:​148:​42
    _tabBarItemSelected @ TabBrowser.js:​246:​55
    dispatch @ Object.js:​134:​35
    dispatchEventToListeners @ Object.js:​142:​17
    selectTabBarItem @ TabBar.js:​402:​38
    _handleTabContainerMouseDown @ TabBar.js:​698:​30
```
Comment 1 Razvan Caliman 2023-06-15 08:12:05 PDT 
rdar://110119826
Comment 2 Razvan Caliman 2023-06-15 08:16:17 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15004
Comment 3 EWS 2023-06-15 14:05:05 PDT 
Committed 265209@main (1ea561941b37): <https://commits.webkit.org/265209@main>

Reviewed commits have been landed. Closing PR #15004 and removing active labels.