Bug 258154 - Serialization algorithms should not be changed in the middle of a serialization
Summary: Serialization algorithms should not be changed in the middle of a serialization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-15 13:25 PDT by Chris Dumez
Modified: 2023-06-16 09:51 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-06-15 13:25:31 PDT
Some of the code in MarkupAccumulator would rely on the node's document to determine whether or not to use the XML or HTML serialization algorithm instead of using the serialization algorithm passed to the MarkupAccumulator constructor. This is often fine but leads to behavior changes when the node is a <template> since they have their own template document.

This meant that we may start serialization as HTML and then switch to XML for serialization a particular template node.
Comment 1 Chris Dumez 2023-06-15 13:31:08 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15016
Comment 2 EWS 2023-06-16 09:50:15 PDT
Committed 265248@main (bb36b71707e3): <https://commits.webkit.org/265248@main>

Reviewed commits have been landed. Closing PR #15016 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-06-16 09:51:18 PDT
<rdar://problem/110905261>