WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
258167
Check CachedResourceLoader's document WeakPtr in more places
https://bugs.webkit.org/show_bug.cgi?id=258167
Summary
Check CachedResourceLoader's document WeakPtr in more places
Brent Fulgham
Reported
2023-06-15 15:37:52 PDT
The CachedResourceLoader class holds a WeakPtr to a Document, which may be nullptr at different moments in loading. We inconsistently check for nullptr, which telemetry shows is triggering some crashes. This patch provides more rigorous checks for nullptr to avoid these crashes.
Attachments
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2023-06-15 15:38:01 PDT
<
rdar://106964279
>
Brent Fulgham
Comment 2
2023-06-15 15:50:21 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/15025
EWS
Comment 3
2023-06-16 16:22:18 PDT
Committed
265259@main
(9632def06c0f): <
https://commits.webkit.org/265259@main
> Reviewed commits have been landed. Closing PR #15025 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug