Bug 258199 - REGRESSION(264826@main): [GStreamer] Fill information on the gst GL context
Summary: REGRESSION(264826@main): [GStreamer] Fill information on the gst GL context
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-16 06:01 PDT by Carlos Garcia Campos
Modified: 2023-06-19 03:11 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-06-16 06:01:48 PDT
In 264826@main I removed the activate and fill of the gst GL context, confused by the API docs of gst_gl_context_fill_info() that says that it's typically used with wrapped contexts to allow wrapped contexts to be used as regular GstGLContexts. We don't want it to be used as a regular context, but the regular context uses the filled information of the sharing context to get the EGL config.
Comment 1 Carlos Garcia Campos 2023-06-16 06:03:48 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15046
Comment 2 EWS 2023-06-19 03:10:39 PDT
Committed 265302@main (06c5a9867e9b): <https://commits.webkit.org/265302@main>

Reviewed commits have been landed. Closing PR #15046 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-06-19 03:11:16 PDT
<rdar://problem/110994734>