Bug 258249 - [FFC] FlexLayout::computeAvailableMainAndCrossSpace should follow spec language
Summary: [FFC] FlexLayout::computeAvailableMainAndCrossSpace should follow spec language
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 258235
  Show dependency tree / graph
 
Reported: 2023-06-17 10:16 PDT by zalan
Modified: 2023-06-19 12:54 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.50 KB, patch)
2023-06-17 10:19 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (2.44 KB, patch)
2023-06-19 08:26 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-06-17 10:16:37 PDT 
ssia
Comment 1 zalan 2023-06-17 10:19:08 PDT 
Created attachment 466737 [details]
Patch
Comment 2 Antti Koivisto 2023-06-18 11:31:52 PDT 
Comment on attachment 466737 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=466737&action=review

> Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:131
> +    auto computeFinalSize = [&](auto& candidateSizes, auto& finalSize) {

wouldn't it be cleaner to just return the finalSize?
Comment 3 zalan 2023-06-19 08:26:52 PDT 
Created attachment 466760 [details]
[fast-cq]Patch
Comment 4 zalan 2023-06-19 08:27:12 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 466737 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=466737&action=review
> 
> > Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:131
> > +    auto computeFinalSize = [&](auto& candidateSizes, auto& finalSize) {
> 
> wouldn't it be cleaner to just return the finalSize?
yeah, not sure what happened here.
Comment 5 EWS 2023-06-19 10:47:52 PDT 
Committed 265308@main (521acb6278c9): <https://commits.webkit.org/265308@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466760 [details].
Comment 6 Radar WebKit Bug Importer 2023-06-19 10:48:16 PDT 
<rdar://problem/111006977>