Bug 258275 - REGRESSION(263809@main): [UNIX] SharedMemory::map is leaking the file descriptor
Summary: REGRESSION(263809@main): [UNIX] SharedMemory::map is leaking the file descriptor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk, InRadar, Regression
Depends on:
Blocks:
 
Reported: 2023-06-19 06:03 PDT by Carlos Garcia Campos
Modified: 2023-12-15 12:07 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-06-19 06:03:54 PDT 
Once mapped, we don't need to keep the file descriptor open. Before 263809@main, we cleared the file descriptor after the mmap call, then created an instance with -1 as fd. Now we are creating the new instance with the handle fd moved.
Comment 1 Carlos Garcia Campos 2023-06-19 06:05:39 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15090
Comment 2 EWS 2023-06-20 10:50:19 PDT 
Committed 265326@main (901d1f8cc477): <https://commits.webkit.org/265326@main>

Reviewed commits have been landed. Closing PR #15090 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-06-20 10:51:18 PDT 
<rdar://problem/111050903>