Bug 258366 - [webkitpy] Avoid autoinstalling libraries in init
Summary: [webkitpy] Avoid autoinstalling libraries in init
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-21 13:25 PDT by Jonathan Bedard
Modified: 2023-06-21 16:42 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-06-21 13:25:08 PDT
webkitpy's __init__.py configures the autoinstaller. It should not actually install packages until we need to use packages. We import webkitscmpy because there are some common dependencies defined in that library. But we also _install_ some of those dependencies on import, which is not nessesary. We should re-organize webkitscmpy and webkitbugspy to avoid installing libraries on import.
Comment 1 Radar WebKit Bug Importer 2023-06-21 13:26:02 PDT
<rdar://problem/111120365>
Comment 2 Jonathan Bedard 2023-06-21 13:34:18 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15157
Comment 3 EWS 2023-06-21 16:42:48 PDT
Committed 265377@main (5f9e420cedb1): <https://commits.webkit.org/265377@main>

Reviewed commits have been landed. Closing PR #15157 and removing active labels.