Bug 258405 - Clean-up RenderFrameSet.cpp|h by removing dead code
Summary: Clean-up RenderFrameSet.cpp|h by removing dead code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-22 09:17 PDT by Ahmad Saleem
Modified: 2023-06-22 11:59 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-06-22 09:17:56 PDT 
Hi Team,

While going through Blink's commit, I came across potential opportunity to do some 'simplify' and 'clean-up' in 'RenderFrameSet' layout & rendering code:

Blink Commit (1): https://src.chromium.org/viewvc/blink?view=revision&revision=171899

- Deleting RenderFrameSet::isResizingRow() & RenderFrameSet::isResizingColumn()

Blink Commit (2): https://chromium.googlesource.com/chromium/src.git/+/7985904656b18a02548afcf98cce20f3353a73f9

- https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderFrameSet.cpp#60 (Deleting 'm_isChildResizing' & removing 'Line 593 & 594')

Just wanted to raise so we can do this clean-up.

@Alan & @Simon - any comment?

Thanks!
Comment 1 EWS 2023-06-22 11:58:41 PDT 
Committed 265417@main (d0daa5ec56a5): <https://commits.webkit.org/265417@main>

Reviewed commits have been landed. Closing PR #15197 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-06-22 11:59:17 PDT 
<rdar://problem/111174263>