WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
258405
Clean-up RenderFrameSet.cpp|h by removing dead code
https://bugs.webkit.org/show_bug.cgi?id=258405
Summary
Clean-up RenderFrameSet.cpp|h by removing dead code
Ahmad Saleem
Reported
2023-06-22 09:17:56 PDT
Hi Team, While going through Blink's commit, I came across potential opportunity to do some 'simplify' and 'clean-up' in 'RenderFrameSet' layout & rendering code: Blink Commit (1):
https://src.chromium.org/viewvc/blink?view=revision&revision=171899
- Deleting RenderFrameSet::isResizingRow() & RenderFrameSet::isResizingColumn() Blink Commit (2):
https://chromium.googlesource.com/chromium/src.git/+/7985904656b18a02548afcf98cce20f3353a73f9
-
https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderFrameSet.cpp#60
(Deleting 'm_isChildResizing' & removing 'Line 593 & 594') Just wanted to raise so we can do this clean-up. @Alan & @Simon - any comment? Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
EWS
Comment 1
2023-06-22 11:58:41 PDT
Committed
265417@main
(d0daa5ec56a5): <
https://commits.webkit.org/265417@main
> Reviewed commits have been landed. Closing PR #15197 and removing active labels.
Radar WebKit Bug Importer
Comment 2
2023-06-22 11:59:17 PDT
<
rdar://problem/111174263
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug