Bug 258418 - Simplify a case statement in Decimal.cpp slightly
Summary: Simplify a case statement in Decimal.cpp slightly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-22 13:52 PDT by Ahmad Saleem
Modified: 2023-06-27 16:24 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-06-22 13:52:49 PDT 
Hi Team,

This is more of clean-up based on Blink's commit.

Commit: https://src.chromium.org/viewvc/blink?view=revision&revision=164071

Just wanted to merge it in WebKit, since it is just clean-up.

Thanks!
Comment 1 Karl Dubost 2023-06-22 18:31:09 PDT 
The description in Chromium

> Simplify a case statement in Decimal.cpp slightly.
> 
> Handling for StateDot and StateDotDigit was identical save for a
> "state = StateDotDigit;" in the StateDot case that's a no-op in the
> StateDotDigit case anyway.

https://github.com/WebKit/WebKit/blob/5fa64072e2f447b7ec80714e07bd5c4380c2714f/Source/WebCore/platform/Decimal.cpp#L752-L778
Comment 2 EWS 2023-06-27 16:23:35 PDT 
Committed 265567@main (2b9d1a6ea04f): <https://commits.webkit.org/265567@main>

Reviewed commits have been landed. Closing PR #15211 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-06-27 16:24:15 PDT 
<rdar://problem/111419452>