Bug 258509 - [Curl] Coding style issue in ResourceResponse.h
Summary: [Curl] Coding style issue in ResourceResponse.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-26 00:20 PDT by Kenji Shukuwa
Modified: 2023-06-26 20:41 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenji Shukuwa 2023-06-26 00:20:37 PDT 
ERROR: Source/WebCore/platform/network/curl/ResourceResponse.h:63:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Comment 1 Kenji Shukuwa 2023-06-26 00:34:45 PDT 
Removing WEBCORE_EXPORT from a class means adding WEBCORE_EXPORT to many functions.

However, if you remove the functions that hide status code checks such as isMovedPermanently and write the status code directly in the code like other ports, they will be unnecessary.

I would like to refer to the SOUP port and modify the code.
Comment 2 Kenji Shukuwa 2023-06-26 00:37:29 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15287
Comment 3 EWS 2023-06-26 20:40:57 PDT 
Committed 265537@main (593b1ac94072): <https://commits.webkit.org/265537@main>

Reviewed commits have been landed. Closing PR #15287 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-06-26 20:41:35 PDT 
<rdar://problem/111368722>