Bug 258517 - Source/JavaScriptCore/CMakeLists.txt: putting __TIMESTAMP__ into a generated file is non-reproducible behavior
Summary: Source/JavaScriptCore/CMakeLists.txt: putting __TIMESTAMP__ into a generated...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 252308 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-06-26 05:58 PDT by Alexander Kanavin
Modified: 2023-08-10 14:22 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kanavin 2023-06-26 05:58:25 PDT 
__TIMESTAMP__ refers to mtime of the file that contains it, which is unstable
and breaks binary reproducibility when the file is generated at build time. To ensure
this does not happen, mtime should be set from the original file.
Comment 1 Michael Catanzaro 2023-06-26 13:56:46 PDT 

*** This bug has been marked as a duplicate of bug 252308 ***
Comment 2 EWS 2023-07-26 12:15:39 PDT 
Committed 266322@main (8e2834324073): <https://commits.webkit.org/266322@main>

Reviewed commits have been landed. Closing PR #15293 and removing active labels.
Comment 3 Michael Catanzaro 2023-08-10 14:22:42 PDT 
*** Bug 252308 has been marked as a duplicate of this bug. ***