Bug 258536 - Bump process priority during responsiveness checks to avoid false positives
Summary: Bump process priority during responsiveness checks to avoid false positives
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 258624
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-26 15:28 PDT by Chris Dumez
Modified: 2023-06-28 08:40 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2023-06-26 15:28:24 PDT
We recently adopted RunningBoard on macOS and our child processes priorities are now tied to RunningBoard assertions that we hold on their behalf. This means that WebProcesses backing background tabs now get a much lower process priority than they used to. Given that the responsiveness timeout is fairly short (3 seconds), this can lead to false positives.

To address the issue, we now hold a foreground assertion during the responsiveness check instead of the implicit background one taken by sendWithAsyncReply().
Comment 1 Chris Dumez 2023-06-26 15:29:58 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15307
Comment 2 EWS 2023-06-26 16:18:39 PDT
Committed 265532@main (5b1e40d5fffc): <https://commits.webkit.org/265532@main>

Reviewed commits have been landed. Closing PR #15307 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-06-26 16:19:16 PDT
<rdar://problem/111354639>
Comment 4 WebKit Commit Bot 2023-06-28 08:40:30 PDT
Re-opened since this is blocked by bug 258624