Bug 258605 - Generated IPC serializers use deprecated stream input operator
Summary: Generated IPC serializers use deprecated stream input operator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-27 23:22 PDT by Kimmo Kinnunen
Modified: 2023-07-03 05:17 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2023-06-27 23:22:03 PDT 
Generated IPC serializers use deprecated stream input operator

Pattern is deprecated:
    std::optional<T> result;
    decoder >> result;

This is on the grounds of it not supporting non-default-constructible T.
This means we have to have support for: 
    auto result = decoder.decode<T>();

Since we need latter anyway, we having the former is redundant.
Comment 1 Radar WebKit Bug Importer 2023-06-27 23:22:15 PDT 
<rdar://problem/111435260>
Comment 2 Kimmo Kinnunen 2023-06-27 23:28:54 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15358
Comment 3 EWS 2023-07-03 05:17:50 PDT 
Committed 265715@main (de84aa87132c): <https://commits.webkit.org/265715@main>

Reviewed commits have been landed. Closing PR #15358 and removing active labels.