Bug 258613 - import-w3c-tests is deleting -expected.txt files of variant test files
Summary: import-w3c-tests is deleting -expected.txt files of variant test files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-28 00:29 PDT by youenn fablet
Modified: 2023-08-04 10:05 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2023-06-28 00:29:00 PDT 
When reimporting webcodecs tests, I can see files like LayoutTests/imported/w3c/web-platform-tests/webcodecs/reconfiguring-encoder.https.any_h264_avc-expected.txt being removed while they should not.
We might want to refine our deletion heuristic.
Comment 1 Radar WebKit Bug Importer 2023-07-05 00:29:16 PDT 
<rdar://problem/111770351>
Comment 2 Sam Sneddon [:gsnedders] 2023-08-03 07:35:22 PDT 
This is webkitpy.w3c.test_importer.TestImporter.remove_dangling_expectations; compare/contrast the logic there with that of webkitpy.port.base.Port._expected_baselines_for_suffixes.

Note that this runs unconditionally (i.e., even without --clean-dest-dir).
Comment 3 Sam Sneddon [:gsnedders] 2023-08-03 09:55:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/16348
Comment 4 EWS 2023-08-04 10:05:33 PDT 
Committed 266588@main (d8e12ca3753d): <https://commits.webkit.org/266588@main>

Reviewed commits have been landed. Closing PR #16348 and removing active labels.