Bug 258622 - Selection should not set the cursor type to text over the explicitly set cursor type
Summary: Selection should not set the cursor type to text over the explicitly set curs...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BrowserCompat, InRadar
Depends on:
Blocks:
 
Reported: 2023-06-28 06:43 PDT by Ahmad Saleem
Modified: 2023-06-28 13:47 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-06-28 06:43:51 PDT
Hi Team,

While going through Blink's commit, I came across another failing test in Safari Technology Preview 172 and WebKit ToT while passing in Chrome Canary 117 and Firefox Nightly 116.

Test Case: https://jsfiddle.net/qe3dkgaw/show

^ Open and drag select text, Safari will have 'I-Beam' (text) cursor while others will have 'progress' cursor.

Blink Commit: https://chromium.googlesource.com/chromium/blink/+/a5c471c481544403615780bce2845de58e37e341%5E%21/#F2

WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/page/EventHandler.cpp#1555

This commit does not modify single thing but just pushes the 'if' below 'switch' case. In local testing, now we pass attached test case at least in "Minibrowser" and get 'progress' cursor.

Thanks!
Comment 1 EWS 2023-06-28 13:46:49 PDT
Committed 265597@main (15042015b0c8): <https://commits.webkit.org/265597@main>

Reviewed commits have been landed. Closing PR #15372 and removing active labels.
Comment 2 Radar WebKit Bug Importer 2023-06-28 13:47:17 PDT
<rdar://problem/111469521>