Bug 258634 - gperf generated files include absolute path to Xcode
Summary: gperf generated files include absolute path to Xcode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-28 12:12 PDT by Elliott Williams
Modified: 2023-07-10 14:56 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2023-06-28 12:12:38 PDT 
This is problematic for compilation caching since changing the path to Xcode causes a cache miss.
Comment 1 Elliott Williams 2023-06-28 12:13:04 PDT 
rdar://111130168
Comment 2 Elliott Williams 2023-06-28 15:07:29 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15383
Comment 3 EWS 2023-06-28 18:16:30 PDT 
Committed 265608@main (acbbcc88d48b): <https://commits.webkit.org/265608@main>

Reviewed commits have been landed. Closing PR #15383 and removing active labels.
Comment 4 EWS 2023-07-03 14:39:02 PDT 
Committed 265738@main (b305f64a67e2): <https://commits.webkit.org/265738@main>

Reviewed commits have been landed. Closing PR #15515 and removing active labels.
Comment 5 Robert Jenner 2023-07-03 14:40:33 PDT 
(In reply to EWS from comment #4)
> Committed 265738@main (b305f64a67e2):
> <https://commits.webkit.org/265738@main>
> 
> Reviewed commits have been landed. Closing PR #15515 and removing active
> labels.

Re-opening after I reverted this commit. Commit was reverted because it broke testing.
Comment 6 EWS 2023-07-10 14:56:04 PDT 
Committed 265919@main (4d2ddeedb04d): <https://commits.webkit.org/265919@main>

Reviewed commits have been landed. Closing PR #15704 and removing active labels.