Bug 258673 - GraphicsContextState returns it has inline changes when it does not have any change
Summary: GraphicsContextState returns it has inline changes when it does not have any ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-29 08:09 PDT by Said Abou-Hallawa
Modified: 2023-06-30 10:07 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-06-29 08:09:19 PDT 
GraphicsContextState::containsOnlyInlineChanges() and GraphicsContextState::containsOnlyInlineStrokeChanges() should return false when the m_changeFlags is empty.
Comment 1 Radar WebKit Bug Importer 2023-06-29 08:09:37 PDT 
<rdar://problem/111513820>
Comment 2 Said Abou-Hallawa 2023-06-29 08:19:02 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15407
Comment 3 Said Abou-Hallawa 2023-06-29 13:05:00 PDT 
These two functions were return true for the empty case which is wrong. This makes Recorder::strokePath() call recordStrokeLineWithColorAndThickness() more often which causes more IPC bytes to be sent to GPUP. It also causes unnecessary DisplayList items to be handled by RemoteDisplayListRecorder::strokeLineWithColorAndThickness().
Comment 4 EWS 2023-06-29 13:16:57 PDT 
Committed 265627@main (3f9ec4370045): <https://commits.webkit.org/265627@main>

Reviewed commits have been landed. Closing PR #15407 and removing active labels.