Bug 258734 - REGRESSION(265569@main): All path segments should be coded by StreamConnectionEncoder
Summary: REGRESSION(265569@main): All path segments should be coded by StreamConnectio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-30 08:30 PDT by Said Abou-Hallawa
Modified: 2023-06-30 19:44 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-06-30 08:30:23 PDT
After 265569@main, the composite path segments, such as PathDataLine, became decodable by IPC coders only. We need to add StreamConnectionEncoder as additional coder for encoding and decoding them. The reason for this change in 265569@main, was the serialization.in files do not know hot to deal with template struct/class. These composite path segments are defined as templates for two types. So the encoding/decoding code was implemented in WebCoreArgumentCoders.h. This caused a perf regression in MotionMark CanvasLines subtest.
Comment 1 Radar WebKit Bug Importer 2023-06-30 08:30:45 PDT
<rdar://problem/111570644>
Comment 2 Said Abou-Hallawa 2023-06-30 09:15:58 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15451
Comment 3 EWS 2023-06-30 19:27:22 PDT
Committed 265680@main (7dc4e7c7d38b): <https://commits.webkit.org/265680@main>

Reviewed commits have been landed. Closing PR #15451 and removing active labels.