Bug 258758 - Restore Path cheap copying (refcount/COW PathStream)
Summary: Restore Path cheap copying (refcount/COW PathStream)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-06-30 17:17 PDT by Simon Fraser (smfr)
Modified: 2023-07-06 10:02 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2023-06-30 17:17:32 PDT 
After 265569@main, copying a Path with a PathStream impl results in cloning the PathStream, which might be large. This breaks the assumption of most of the existing code, that copying a Path is cheap because it's just refCounting a CGPathRef.

So we should restore cheap copy, and make the PathStream copy-on-write.
Comment 1 Radar WebKit Bug Importer 2023-06-30 17:18:03 PDT 
<rdar://problem/111595182>
Comment 2 Simon Fraser (smfr) 2023-07-05 17:44:15 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15584
Comment 3 EWS 2023-07-06 10:01:58 PDT 
Committed 265810@main (bb3cac815bdf): <https://commits.webkit.org/265810@main>

Reviewed commits have been landed. Closing PR #15584 and removing active labels.