Bug 258819 - [ews] Build failure notification step fails with: 'ascii' codec can't encode character '\u2018' in position 777: ordinal not in range(128)
Summary: [ews] Build failure notification step fails with: 'ascii' codec can't encode ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-03 12:24 PDT by Abrar Rahman Protyasha
Modified: 2023-07-03 13:42 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Abrar Rahman Protyasha 2023-07-03 12:24:56 PDT
I came across an encoding exception on EWS (in `Tools.CISupport.ews-build.send_email_for_new_build_failure()`) for one of my PRs -- https://ews-build.webkit.org/#/builders/2/builds/13740.

The standard output for the failing stage reads: `Sending email notification to a_protyasha@apple.comError in sending email for new build failure: 'ascii' codec can't encode character '\u2018' in position 777: ordinal not in range(128)`

For more context, the associated build failure is provided below, though I doubt it is related:

```
/app/webkit/Source/WebCore/dom/TouchEvent.cpp: In member function 'void WebCore::TouchEvent::initTouchEvent(WebCore::TouchList*, WebCore::TouchList*, WebCore::TouchList*, const WTF::AtomString&, WTF::RefPtr<WebCore::WindowProxy>&&, int, int, int, int, bool, bool, bool, bool)':
/app/webkit/Source/WebCore/dom/TouchEvent.cpp:74:5: error: 'WebCore::IntPoint WebCore::MouseRelatedEvent::m_screenLocation' is private within this context
```
Comment 1 Radar WebKit Bug Importer 2023-07-03 12:25:06 PDT
<rdar://problem/111700007>
Comment 2 Alexey Proskuryakov 2023-07-03 12:35:45 PDT
Looks like gcc emits curly quotes when the locale is UTF-8: https://stackoverflow.com/questions/2443991/g-curly-quotes-displayed-incorrectly-in-console-and-problems-list

We should make UTF-8 work end to end here (including email generation). But if that's tricky, a short term workaround would be to set a non-UTF locale when building.