Bug 258844 - Attachment: Icon should be hidden when there is progress or a placeholder
Summary: Attachment: Icon should be hidden when there is progress or a placeholder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gerald Squelart
URL:
Keywords: InRadar
Depends on: 258437
Blocks:
  Show dependency tree / graph
 
Reported: 2023-07-03 21:41 PDT by Gerald Squelart
Modified: 2023-07-05 18:47 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Squelart 2023-07-03 21:41:30 PDT 
Bug 258437 changed how the attachment icon is implemented: Instead of an inner attachment, it is now an image.
Unfortunately in that change, the `HTMLAttachmentElement::updateProgress` function was incorrectly changed and does not properly hide the icon anymore.

To fix: In https://github.com/WebKit/WebKit/pull/15228/files#diff-81277d6d3423f470d7dc5e5b8f50ab5b7a766baeeb1a640d66b5db0edd617312L305 , the m_innerLegacyAttachment->set/removeInlineStyleProperty lines should be put back, but operating on m_imageElement instead.
Comment 1 Radar WebKit Bug Importer 2023-07-03 21:41:38 PDT 
<rdar://problem/111720923>
Comment 2 Gerald Squelart 2023-07-03 22:02:22 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15531
Comment 3 EWS 2023-07-05 18:47:03 PDT 
Committed 265785@main (a9b327ab90e2): <https://commits.webkit.org/265785@main>

Reviewed commits have been landed. Closing PR #15531 and removing active labels.