Bug 258845 - Fix checkSwitchToJITForLoop on ARM64E to work with --returnEarlyFromInfiniteLoopsForFuzzing=1 --useJIT=0.
Summary: Fix checkSwitchToJITForLoop on ARM64E to work with --returnEarlyFromInfiniteL...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-07-03 22:25 PDT by Mark Lam
Modified: 2023-07-04 16:33 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2023-07-03 22:25:59 PDT
On ARM64E, checkSwitchToJITForLoop() assumes that we can always dispatch thru g_jscConfig.llint.gateMap[Gate::loopOSREntry], which is normally a JIT thunk.  However, this entry is null when --useJIT=0.  Fix this by implementing a LLInt only thunk that achieves the same thing.
Comment 1 Radar WebKit Bug Importer 2023-07-03 22:26:31 PDT
<rdar://problem/111722535>
Comment 2 Mark Lam 2023-07-03 22:33:39 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15533
Comment 3 EWS 2023-07-04 16:33:40 PDT
Committed 265760@main (d89d75b2f665): <https://commits.webkit.org/265760@main>

Reviewed commits have been landed. Closing PR #15533 and removing active labels.