RESOLVED FIXED258868
Correctly compute baseline of wide-layout attachments 
https://bugs.webkit.org/show_bug.cgi?id=258868
Summary Correctly compute baseline of wide-layout attachments
Gerald Squelart
Reported 2023-07-05 01:12:55 PDT
Currently it's falling back on the narrow/legacy renderer's baseline computation, which happens to look okay. This should be fixed to have a proper computation. Also, because it's currently going through the legacy layout path, HTMLAttachmentElement::requestIconWithSize triggers its debug-assertion that it should only be used with a narrow/legacy attachment; in release it doesn't crash but probably does an extra unnecessary icon request.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-07-05 01:13:06 PDT
<rdar://problem/111771870>
Gerald Squelart
Comment 2 2023-07-05 01:19:55 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15558
EWS
Comment 3 2023-07-06 18:58:49 PDT
Committed 265831@main (ee150aed9da8): <https://commits.webkit.org/265831@main> Reviewed commits have been landed. Closing PR #15558 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.