Bug 258868 - Correctly compute baseline of wide-layout attachments
Summary: Correctly compute baseline of wide-layout attachments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gerald Squelart
URL:
Keywords: InRadar
Depends on:
Blocks: 259172 259039
  Show dependency tree / graph
 
Reported: 2023-07-05 01:12 PDT by Gerald Squelart
Modified: 2023-07-12 20:54 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Squelart 2023-07-05 01:12:55 PDT 
Currently it's falling back on the narrow/legacy renderer's baseline computation, which happens to look okay.
This should be fixed to have a proper computation.

Also, because it's currently going through the legacy layout path, HTMLAttachmentElement::requestIconWithSize triggers its debug-assertion that it should only be used with a narrow/legacy attachment; in release it doesn't crash but probably does an extra unnecessary icon request.
Comment 1 Radar WebKit Bug Importer 2023-07-05 01:13:06 PDT 
<rdar://problem/111771870>
Comment 2 Gerald Squelart 2023-07-05 01:19:55 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/15558
Comment 3 EWS 2023-07-06 18:58:49 PDT 
Committed 265831@main (ee150aed9da8): <https://commits.webkit.org/265831@main>

Reviewed commits have been landed. Closing PR #15558 and removing active labels.